opentelemetry-python
opentelemetry-python copied to clipboard
open-telemetry
Add ARM64 Support
Hi Team,
I'm working on testing opentelemetry python language library for arm64 platform.
Is your feature request related to a problem? The python language library doesn’t have arm64 platform support.
Describe the solution you'd like I have explored the repository and CI being used in this library, arm64 builds can be added in the GitHub actions CI to enable test in the library for arm64.
Describe alternatives you've considered As discussed on the issue, I have added support in GitHub actions to add builds for testing the library although some tests are failing.
Please have a look at the logs: https://github.com/odidev/opentelemetry-python/actions/runs/2336787293
Additional context As shown in the above logs only 2 test scenarios are failing for arm64 in GitHub actions please find below the reason for the same:
-
Misc ( tracecontext ): There are 8 test failures in GitHub actions although when I ran the tests in my local arm64 machine all the test cases are passing. Please have a look at the logs: tracecontext-arm64-logs.txt
-
Misc (docker-tests): Getting file not found error in GitHub actions build although getting different error when I tested in my local arm64 machine (all 3 test cases are failing in both). Please have a look at the logs: docker-tests-arm64-logs.txt
Do you have any plans for supporting the arm64 platform? It will be very helpful if arm64 support is available in the library.
Please share your thoughts on this.
What is it specifically that py packages do that doesn't work on arm64? All packages pass the tests and those misc are integrations tests that spin up the web, db servers which might requires some changes to scripts.
@srikanthccv Thanks for the quick response.
What is it specifically that py packages do that doesn't work on arm64?
I have explored and Misc ( tracecontext ) tests are only failing in GitHub actions for arm64 and passing successfully in my local arm64 server, please have a look at the logs: tracecontext-arm64-logs.txt
Although the Misc (docker-tests) are failing both in GitHub actions and in my local arm64 server but with different errors I will be happy to help if you could share some pointers as to how to resolve the above issue.
It's not the tests that are failing. There is some pre test setup for integration tests which requires some modification on arm to get it up before the actual tests run.
@srikanthccv As per your pointers I explored regarding the pre tests setup for integration tests and it looks like the docker-compose.yml needs to be modified in order to make it work on the arm64 platform.
Although the omnition/opencensus-collector image used here only supports amd64 platform and is not available for arm64 I am not able to find the dockerfile for the same too.
It would be really helpful if you could share the link of the dockerfile so that I can work on building the image for arm64 and raise PR for the same.
Please share your thoughts on this.
@odidev there is no known arm64 image for opencensus collector. But it doesn't change anything from an exporter pov because the backend receiver is an independent component outside its scope. If any package provided by OTEL doesn't work on arm64 please let us know with more details.
Closing this since there is nothing we do specifically about the CPU architectures (at least for now).