opentelemetry-php icon indicating copy to clipboard operation
opentelemetry-php copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

[META] php 8.2 support

Open brettmc opened this issue 3 years ago • 2 comments
trafficstars

Issues to be resolved to enable opentelemetry-php to work with php 8.2:

  • [x] ${var} in strings https://github.com/open-telemetry/opentelemetry-php/pull/810
  • [x] protobuf (native) https://github.com/protocolbuffers/protobuf/pull/10594
  • [x] protobuf (extension) (dynamic properties) - extension v3.20.1+ is ok
  • [ ] grpc (dynamic properties) https://github.com/grpc/grpc/pull/30997

brettmc avatar Sep 16 '22 06:09 brettmc

All the PRs are in for this, we are just waiting on Google support. I'm going to follow up with them.

bobstrecansky avatar Oct 12 '22 12:10 bobstrecansky

I've bumped our Google support rep today; waiting to hear back from them.

bobstrecansky avatar Oct 12 '22 18:10 bobstrecansky

gRPC and protobuf PRs have been merged, now to wait for them to be included in releases.

brettmc avatar Oct 26 '22 23:10 brettmc

I'm going to ping our google rep about a release of https://github.com/protocolbuffers/protobuf

bobstrecansky avatar Nov 30 '22 13:11 bobstrecansky

22.10 was released a couple of hours ago (coincidence?) but it doesn't include my changes.

Since the issue only affects the native php protobuf implementation (which we discourage using in favour of the extension), I'm ok with just calling this done.

brettmc avatar Nov 30 '22 21:11 brettmc

I'm going to close this, since the only outstanding issue (protobuf) shouldn't affect us (since we strongly encourage using the extension). One last thing to note, is that php-cs-fixer isn't certified against 8.2, and until it is make style will complain.

brettmc avatar Dec 21 '22 02:12 brettmc