opentelemetry-php-contrib
opentelemetry-php-contrib copied to clipboard
implement rule-based sampler
Ported rule-based sampler from https://github.com/Nevay/otel-sdk-contrib-sampler
Co-authored-by: Tobias Bachert [email protected]
Codecov Report
Attention: Patch coverage is 32.14286% with 114 lines in your changes missing coverage. Please review.
Project coverage is 82.68%. Comparing base (
727236e) to head (75c26b6). Report is 10 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #279 +/- ##
============================================
+ Coverage 82.45% 82.68% +0.23%
+ Complexity 1073 948 -125
============================================
Files 104 89 -15
Lines 4480 3807 -673
============================================
- Hits 3694 3148 -546
+ Misses 786 659 -127
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files with missing lines | Coverage Δ | |
|---|---|---|
| src/Sampler/RuleBased/src/RuleBasedSampler.php | 100.00% <100.00%> (ø) |
|
| src/Sampler/RuleBased/src/RuleSet.php | 100.00% <100.00%> (ø) |
|
| ...mpler/RuleBased/src/SamplingRule/AttributeRule.php | 100.00% <100.00%> (ø) |
|
| ...rc/Sampler/RuleBased/src/SamplingRule/LinkRule.php | 100.00% <100.00%> (ø) |
|
| .../Sampler/RuleBased/src/SamplingRule/ParentRule.php | 100.00% <100.00%> (ø) |
|
| ...ampler/RuleBased/src/SamplingRule/SpanKindRule.php | 100.00% <100.00%> (ø) |
|
| ...ampler/RuleBased/src/SamplingRule/SpanNameRule.php | 100.00% <100.00%> (ø) |
|
| ...leBased/src/ComponentProvider/SamplingRuleLink.php | 0.00% <0.00%> (ø) |
|
| ...Based/src/ComponentProvider/SamplingRuleParent.php | 0.00% <0.00%> (ø) |
|
| ...sed/src/ComponentProvider/SamplingRuleSpanName.php | 0.00% <0.00%> (ø) |
|
| ... and 3 more |
... and 33 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 727236e...75c26b6. Read the comment docs.
I think this is ready for review now, @open-telemetry/php-approvers
There's an OTEP which looks like it will eventually specify a rules-based sampler, so to avoid a future config collision I've changed the key for this one to contrib_rule_based (open to improved names, though!)