opentelemetry-php-contrib icon indicating copy to clipboard operation
opentelemetry-php-contrib copied to clipboard

Add support for OpenSwoole 22.x

Open babenkoivan opened this issue 1 year ago • 6 comments

Coroutine::listCoroutines() has been removed in version 22.0.0 (see the changelog):

Remove deprecated function Coroutine::listCoroutines, use Coroutine::list

This seems to be the only change that prevents using the context with the latest Swoole version. Could you please have a look?

babenkoivan avatar Mar 18 '24 14:03 babenkoivan

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

welcome[bot] avatar Mar 18 '24 14:03 welcome[bot]

CLA Not Signed

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.44%. Comparing base (1e30145) to head (aac0e27). Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #246      +/-   ##
============================================
- Coverage     85.47%   85.44%   -0.03%     
- Complexity      972      973       +1     
============================================
  Files            88       88              
  Lines          3923     3924       +1     
============================================
  Hits           3353     3353              
- Misses          570      571       +1     
Flag Coverage Δ
7.4 85.67% <0.00%> (-0.05%) :arrow_down:
8.0 84.59% <0.00%> (-0.03%) :arrow_down:
8.1 84.70% <0.00%> (-0.03%) :arrow_down:
8.2 85.36% <0.00%> (-0.03%) :arrow_down:
8.3 85.36% <0.00%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Context/Swoole/src/SwooleContextHandler.php 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1e30145...aac0e27. Read the comment docs.

codecov[bot] avatar Mar 20 '24 12:03 codecov[bot]

@babenkoivan - will be happy to review this once you've signed the CLA!

bobstrecansky avatar Mar 27 '24 12:03 bobstrecansky

@babenkoivan just following up on this! Thanks!

bobstrecansky avatar Apr 10 '24 09:04 bobstrecansky

Hey @bobstrecansky, sorry for not replying earlier. I'm currently on a trip without access to my computer. I'll sign the CLA as soon as I'm back.

babenkoivan avatar Apr 10 '24 11:04 babenkoivan

@babenkoivan are you still planning on pushing this forward?

bobstrecansky avatar Jun 26 '24 12:06 bobstrecansky

Hi @bobstrecansky , sorry for not following up on this. It's not needed anymore, the issue can be closed.

babenkoivan avatar Jun 26 '24 13:06 babenkoivan