opentelemetry-operator icon indicating copy to clipboard operation
opentelemetry-operator copied to clipboard

Add Dependabot config for NodeJS autoinstrumentation

Open akselleirv opened this issue 1 year ago • 2 comments
trafficstars

Description:

Added Dependabot for bumping NodeJS updates for the autoinstrumentation with grouping on bump type.

Testing:

Tested the config on my fork. Please see PRs there for how it look like:

  • https://github.com/akselleirv/opentelemetry-operator/pull/2
  • https://github.com/akselleirv/opentelemetry-operator/pull/5

akselleirv avatar Feb 03 '24 11:02 akselleirv

This is really interesting. We've typically only done a release when the nodejs API/SDK has a bump, but I guess there is nothing stopping us from bumping when only the instrumentation has a release.

TylerHelmuth avatar Feb 07 '24 22:02 TylerHelmuth

Can any version be independently bumped https://github.com/open-telemetry/opentelemetry-operator/blob/main/autoinstrumentation/nodejs/package.json?

We might also need to change how we are versioning and when we are releasing the node auto-instrumentation https://github.com/open-telemetry/opentelemetry-operator/blob/main/.github/workflows/publish-autoinstrumentation-nodejs.yaml#L29. Right now it is released only if sdk-node is released.

pavolloffay avatar Feb 09 '24 08:02 pavolloffay

Thanks @akselleirv! I concidered adding dependabot conf myself (because of #2745 to bump @opentelemetry/auto-instrumentations-node), but found your PR :)

atsu85 avatar Mar 11 '24 12:03 atsu85