opentelemetry-operator
opentelemetry-operator copied to clipboard
open-telemetry
Bump go.opentelemetry.io/collector/featuregate from 0.77.0 to 1.0.0
Supersedes #2392. There was a breaking change in the new release.
Looks like dashes are not allowed in feature gate ids in 1.0.0. We'll need to remove the two feature gates we have that use them before we can merge this. It looks like we have a bunch of feature gates in Beta that should really be moved to Stable and removed shortly, so this won't be too much of a problem.
We are currently using feature-gates to manage access to auto-instrumentation. Changing the names will be considered a breaking change and it would likely also be a breaking change to stop managing the feature via feature gates and start managing it another way. Before we take this dependency bump lets agree on a permanent solution for gating auto-instrumentation so we only have to handle 1 breaking change.
TBH I don't like that the operator uses the feature gate package from the collector.
I would prefer to have a separate struct (with flags support for backward compatibility) for all operator configs. The options in the struct could be configured via a config map or flag at the operator startup.
With #2652, we can now merge this and unblock other dependencies that need this.
TBH I don't like that the operator uses the feature gate package from the collector.
I would prefer to have a separate struct (with flags support for backward compatibility) for all operator configs. The options in the struct could be configured via a config map or flag at the operator startup.
I think it's fine to use it if we use it the right way. The target allocator rewrite flag was a good use of the package, as the intent was for the change to eventually be enabled unconditionally. We should just be careful not to add feature flags that should really be permanent command line options.