opentelemetry-lambda icon indicating copy to clipboard operation
opentelemetry-lambda copied to clipboard

Add X-Ray support

Open garasubo opened this issue 3 years ago • 2 comments

Fix #291

Add X-Ray support in ADOT collector

garasubo avatar Sep 27 '22 03:09 garasubo

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: garasubo / name: Takumi Shimada (b132f2279078479663a200bbc3ce5a8e09ea21dd)

@open-telemetry/lambda-extension-maintainers thoughts on this? I'm not sure whether we should include non-OSS exporters in this distribution.

Aneurysm9 avatar Oct 10 '22 16:10 Aneurysm9

This question always comes up from time to time.

We have concluded that we should not include the X-Ray Exporter. This repo serves as a clean foundation for vendors to build their vendor-specific Lambda Layers and distribute with their offerings. The AWS users should use the https://github.com/aws-observability/aws-otel-lambda repository to advance any development on a Lambda Layer which includes the aws-xray-exporter. The aws-otel-lambda repo will always have this opentelemetry-lambda repository as a submodule so it will get the latest features from OTel Lambda without needing to edit the foundation code with Vendor specific X-Ray packages.

NathanielRN avatar Oct 25 '22 16:10 NathanielRN

@NathanielRN Oh, I got it. I didn't know aws-oobservability repository since the document in AWS introduced this repository for the manual setup. Then, it seems better to close it. Thanks for following up.

garasubo avatar Oct 26 '22 14:10 garasubo