opentelemetry-lambda icon indicating copy to clipboard operation
opentelemetry-lambda copied to clipboard

Remove deprecated setting in collector and add https provider

Open vasireddy99 opened this issue 1 year ago • 1 comments

This PR removes deprecated configprovider in collector settings.

Tested using sample app :

  | 2024-04-26T05:26:26.786Z | INIT_START Runtime Version: dotnet:6.v32 Runtime Version ARN: arn:aws:lambda:us-west-2::runtime:c24600438361538bf221f123d3d95263abe4b0950bd08bbb373a224ee1bfdcd7
-- | -- | --
  | 2024-04-26T05:26:27.001Z | {"level":"info","ts":1714109187.0016475,"msg":"Launching OpenTelemetry Lambda extension","version":"v0.98.0"}
  | 2024-04-26T05:26:27.014Z | {"level":"info","ts":1714109187.014217,"logger":"telemetryAPI.Listener","msg":"Listening for requests","address":"sandbox.localdomain:53612"}
  | 2024-04-26T05:26:27.014Z | {"level":"info","ts":1714109187.0143013,"logger":"telemetryAPI.Client","msg":"Subscribing","baseURL":"http://127.0.0.1:9001/2022-07-01/telemetry"}
  | 2024-04-26T05:26:27.018Z | TELEMETRY Name: collector State: Subscribed Types: [Platform]
  | 2024-04-26T05:26:27.024Z | {"level":"info","ts":1714109187.019558,"logger":"telemetryAPI.Client","msg":"Subscription success","response":"\"OK\""}
  | 2024-04-26T05:26:27.052Z | {"level":"info","ts":1714109187.0405838,"caller":"[email protected]/telemetry.go:55","msg":"Setting up own telemetry..."}
  | 2024-04-26T05:26:27.052Z | {"level":"info","ts":1714109187.0431213,"caller":"[email protected]/telemetry.go:97","msg":"Serving metrics","address":"localhost:8888","level":"Basic"}
  | 2024-04-26T05:26:27.055Z | {"level":"info","ts":1714109187.043226,"caller":"[email protected]/exporter.go:275","msg":"Deprecated component. Will be removed in future releases.","kind":"exporter","data_type":"traces","name":"logging"}
  | 2024-04-26T05:26:27.058Z | {"level":"warn","ts":1714109187.0558608,"caller":"common/factory.go:68","msg":"'loglevel' option is deprecated in favor of 'verbosity'. Set 'verbosity' to equivalent value to preserve behavior.","kind":"exporter","data_type":"traces","name":"logging","loglevel":"debug","equivalent verbosity level":"Detailed"}
  | 2024-04-26T05:26:27.058Z | {"level":"info","ts":1714109187.0569685,"caller":"[email protected]/exporter.go:275","msg":"Deprecated component. Will be removed in future releases.","kind":"exporter","data_type":"metrics","name":"logging"}
  | 2024-04-26T05:26:27.058Z | {"level":"info","ts":1714109187.0575562,"caller":"[email protected]/service.go:143","msg":"Starting otelcol-lambda...","Version":"v0.98.0","NumCPU":2}
  | 2024-04-26T05:26:27.058Z | {"level":"info","ts":1714109187.057572,"caller":"extensions/extensions.go:34","msg":"Starting extensions..."}
  | 2024-04-26T05:26:27.058Z | {"level":"info","ts":1714109187.0577004,"caller":"[email protected]/otlp.go:102","msg":"Starting GRPC server","kind":"receiver","name":"otlp","data_type":"metrics","endpoint":"localhost:4317"}
  | 2024-04-26T05:26:27.058Z | {"level":"info","ts":1714109187.0578787,"caller":"[email protected]/otlp.go:152","msg":"Starting HTTP server","kind":"receiver","name":"otlp","data_type":"metrics","endpoint":"localhost:4318"}
  | 2024-04-26T05:26:27.058Z | {"level":"info","ts":1714109187.0579488,"caller":"[email protected]/service.go:169","msg":"Everything is ready. Begin running and processing data."}
  | 2024-04-26T05:26:27.058Z | {"level":"warn","ts":1714109187.0579576,"caller":"localhostgate/featuregate.go:63","msg":"The default endpoints for all servers in components will change to use localhost instead of 0.0.0.0 in a future version. Use the feature gate to preview the new default.","feature gate ID":"component.UseLocalHostAsDefaultHost"}
  | 2024-04-26T05:26:27.385Z | EXTENSION Name: collector State: Ready Events: [INVOKE, SHUTDOWN]
  | 2024-04-26T05:26:27.393Z | START RequestId: d077bfd0-b67e-465e-abe0-ce3185966af4 Version: $LATEST
  | 2024-04-26T05:26:30.733Z | {"level":"info","ts":1714109190.7332761,"msg":"TracesExporter","kind":"exporter","data_type":"traces","name":"logging","resource spans":1,"spans":1}
  | 2024-04-26T05:26:30.733Z | {"level":"info","ts":1714109190.7334428,"msg":"ResourceSpans #0\nResource SchemaURL: \nResource attributes:\n -> cloud.provider: Str(aws)\n -> cloud.region: Str(us-west-2)\n -> faas.name: Str(hello-dotnet-awssdk-wrapper)\n -> faas.version: Str($LATEST)\n -> telemetry.sdk.name: Str(opentelemetry)\n -> telemetry.sdk.language: Str(dotnet)\n -> telemetry.sdk.version: Str(1.1.0.52)\n -> service.name: Str(hello-dotnet-awssdk-wrapper)\nScopeSpans #0\nScopeSpans SchemaURL: \nInstrumentationScope Amazon.AWS.AWSClientInstrumentation \nSpan #0\n Trace ID : 98d3e26df57116f0389f0ad920d5daa4\n Parent ID : \n ID : cc5a62a1977179eb\n Name : S3.ListBuckets\n Kind : Client\n Start time : 2024-04-26 05:26:28.83449 +0000 UTC\n End time : 2024-04-26 05:26:30.175899 +0000 UTC\n Status code : Unset\n Status message : \nAttributes:\n -> aws.service: Str(S3)\n -> aws.operation: Str(ListBuckets)\n -> aws.region: Str(us-west-2)\n -> aws.requestId: Str(2C5ZC2AW6PG98PCD)\n -> http.status_code: Int(200)\n -> http.response_content_length: Int(0)\n","kind":"exporter","data_type":"traces","name":"logging"}
  | 2024-04-26T05:26:31.061Z | END RequestId: d077bfd0-b67e-465e-abe0-ce3185966af4
  | 2024-04-26T05:26:31.061Z | REPORT RequestId: d077bfd0-b67e-465e-abe0-ce3185966af4 Duration: 3668.21 ms Billed Duration: 3669 ms Memory Size: 384 MB Max Memory Used: 138 MB Init Duration: 605.76 ms
  | 2024-04-26T05:32:22.737Z | {"level":"info","ts":1714109542.737256,"logger":"lifecycle.manager","msg":"Received SHUTDOWN event"}
  | 2024-04-26T05:32:22.737Z | {"level":"info","ts":1714109542.7373898,"logger":"telemetryAPI.Listener","msg":"HTTP Server closed:","error":"http: Server closed"}
  | 2024-04-26T05:32:22.737Z | {"level":"info","ts":1714109542.7375185,"caller":"[email protected]/collector.go:286","msg":"Received shutdown request"}
  | 2024-04-26T05:32:22.737Z | {"level":"info","ts":1714109542.7375467,"caller":"[email protected]/service.go:206","msg":"Starting shutdown..."}
  | 2024-04-26T05:32:22.737Z | {"level":"info","ts":1714109542.737677,"caller":"extensions/extensions.go:59","msg":"Stopping extensions..."}
  | 2024-04-26T05:32:22.737Z | {"level":"info","ts":1714109542.7376919,"caller":"[email protected]/service.go:220","msg":"Shutdown complete."}
  | 2024-04-26T05:32:22.737Z | {"level":"info","ts":1714109542.737814,"msg":"done"}


vasireddy99 avatar Apr 26 '24 05:04 vasireddy99

@vasireddy99 is this still needed? I didn't merge as I was hoping for a review from @rapphil, but now it has conflicts.

tylerbenson avatar Aug 21 '24 15:08 tylerbenson

This PR can be closed, it's way behind and this new one seems to fix with the correct version: https://github.com/open-telemetry/opentelemetry-lambda/pull/1601

pragmaticivan avatar Nov 29 '24 16:11 pragmaticivan