opentelemetry-js

opentelemetry-js copied to clipboard

Add attributes parameter to span.recordException

1

As discussed in https://github.com/open-telemetry/opentelemetry-js-api/issues/95 we should add an optional third parameter to `span.recordException` which contains optional attributes to be attached to the event. Relevant specification: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/api.md#record-exception

dyladan

Consider exposing NOOP classes from API packages

1

Original discussion here: https://github.com/open-telemetry/opentelemetry-js-api/pull/174 The original PR didn't really provide any usecases here, but there are certain conditions, particularly around testing, where it may be desireable to have access to...

dyladan

Consider returning noop/non-recording span instead of undefined in the case of no active span

6

Original discussion here: https://github.com/open-telemetry/opentelemetry-js-api/pull/175 Related otep discussion: https://github.com/open-telemetry/oteps/issues/216 The user who opened this PR wanted us to return a valid span object any time there is no active span. The...

dyladan

I want to know whether the nanos length returned by the numberToHrtime method is a fixed length?

7

https://github.com/open-telemetry/opentelemetry-js/blob/369b07e1c7483556fa9da952ba27c2e2828ecefb/packages/opentelemetry-core/src/common/time.ts#L36 I saw this method used in many places, so I tested this method in the development environment. I found that sometimes the length of time obtained is unstable. Sometimes...

yuanman0109

Precision loss on time_unix_nano

2

### What version of OpenTelemetry are you using? v1.0.1 ### What version of Node are you using? v14.18.1 ### Please provide the code you used to set up the OpenTelemetry...

legendecas

By default, the prometheus exporter [appends timestamps to metrics](https://github.com/open-telemetry/opentelemetry-js/blob/b152497e5f77f35c5e49606da5b894bb8e5af00f/experimental/packages/opentelemetry-exporter-prometheus/src/PrometheusExporter.ts#L43). This goes against the current [guidance from OpenMetrics about whether to expose timestamps](https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md#exposing-timestamps). We should consider not adding timestamps by default.

dashpole

### Problem Statement After https://github.com/open-telemetry/opentelemetry-specification/pull/2951, and https://github.com/open-telemetry/opentelemetry-specification/pull/2979, we could implement a metric bridge for OpenCensus. Note that the specifications are experimental, so it isn't critical that it is implemented at...

dashpole

The [current implementation](https://github.com/open-telemetry/opentelemetry-js/blob/main/experimental/packages/opentelemetry-exporter-prometheus/src/PrometheusExporter.ts#LL44C25-L44C25) allows specifying a prefix which is globally applied to all metrics for the exporter. From the [OpenMetrics spec on target metadata](https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md#supporting-target-metadata-in-both-push-based-and-pull-based-systems): > Exposers MUST NOT prefix MetricFamily...

dashpole

Span start and end times in the distant past on chrome

21

### What happened? ## Steps to Reproduce call `trace.getTracer('service').startSpan(...)` without setting `startTime` from an instance of Chrome on version `106.0.5249.119` (i'm not sure exactly how far back [this open bug](https://bugs.chromium.org/p/chromium/issues/detail?id=1365808&q=timeOrigin&can=2)...

MisterSquishy

Prometheus exporter handles instrumentation scope and prevents collisions

4

Now that https://github.com/open-telemetry/opentelemetry-specification/pull/2703 is released, we can update the prometheus exporter to make use of OpenTelemetry scope, particularly for reducing collisions between metrics with the same name. **Describe the solution...

dashpole