opentelemetry-js icon indicating copy to clipboard operation
opentelemetry-js copied to clipboard

`require` calls in `esm` build of `@opentelemetry/resources`

Open madimp opened this issue 1 year ago • 1 comments

What happened?

Steps to Reproduce

index.ts

import { Resource } from '@opentelemetry/resources';

new Resource()

Run ./node_modules/.bin/vite-node index.ts

Expected Result

No Syntax Error

Actual Result

Syntax Error

Additional Details

There should be no require calls for the esm https://github.com/open-telemetry/opentelemetry-js/blob/main/packages/opentelemetry-resources/src/platform/node/machine-id/getMachineId.ts

OpenTelemetry Setup Code

No response

package.json

{
  "name": "esmbug",
  "type": "module",
  "dependencies": {
    "@opentelemetry/resources": "^1.23.0",
    "vite-node": "^1.5.0"
  }
}

Relevant log output

esmbug/node_modules/@opentelemetry/resources/build/esm/platform/node/machine-id/getMachineId-darwin.js:52
import { execAsync } from './execAsync';
^^^^^^

SyntaxError: Cannot use import statement outside a module

madimp avatar Apr 17 '24 09:04 madimp

FYI, this has already had some discussion in #3989

luxaritas avatar May 01 '24 02:05 luxaritas