opentelemetry-js icon indicating copy to clipboard operation
opentelemetry-js copied to clipboard

feat(jaeger-remote-sampler): Implement jaeger remote sampler

Open legalimpurity opened this issue 1 year ago • 3 comments

Which problem is this PR solving?

This is an implementation of JaegerRemoteSampler. This follows the specification mentioned here.

Fixes #4534

Short description of the changes

Add a new samper implementation in experimental packages.

Type of change

Please delete options that are not relevant.

  • [x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Have added full coverage for entire code.

Checklist:

  • [x] Followed the style guidelines of this project
  • [x] Unit tests have been added

legalimpurity avatar Mar 27 '24 12:03 legalimpurity

Codecov Report

Attention: Patch coverage is 94.44444% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 92.86%. Comparing base (2610122) to head (7f476b3). Report is 12 commits behind head on main.

:exclamation: Current head 7f476b3 differs from pull request most recent head b553fbe. Consider uploading reports for the commit b553fbe to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4589      +/-   ##
==========================================
+ Coverage   90.77%   92.86%   +2.08%     
==========================================
  Files          90      331     +241     
  Lines        1930     9571    +7641     
  Branches      417     2054    +1637     
==========================================
+ Hits         1752     8888    +7136     
- Misses        178      683     +505     
Files Coverage Δ
...s/sampler-jaeger-remote/src/JaegerRemoteSampler.ts 100.00% <100.00%> (ø)
...s/sampler-jaeger-remote/src/PerOperationSampler.ts 100.00% <100.00%> (ø)
...mental/packages/sampler-jaeger-remote/src/types.ts 100.00% <100.00%> (ø)
...y-sdk-trace-base/src/sampler/ParentBasedSampler.ts 78.78% <0.00%> (-5.09%) :arrow_down:
...trace-base/src/sampler/TraceIdRatioBasedSampler.ts 92.00% <0.00%> (-8.00%) :arrow_down:

... and 244 files with indirect coverage changes

codecov[bot] avatar Mar 27 '24 15:03 codecov[bot]

Good morning guys? did anyone had a chance to review this?

legalimpurity avatar Apr 10 '24 04:04 legalimpurity

Hello Guys any update here? @pichlermarc

legalimpurity avatar Apr 18 '24 04:04 legalimpurity

Greetings 👋

We're interested in testing this sampler at ebay. What's the current status of this PR? Is there anything I can help with?

dpchamps avatar May 22 '24 16:05 dpchamps

@pichlermarc Can we review pending changes and merge this?

legalimpurity avatar Aug 09 '24 10:08 legalimpurity

@pichlermarc can you have a look at it again?

legalimpurity avatar Aug 14 '24 04:08 legalimpurity

@dyladan would you have time to review this today? I think @pichlermarc is on leave.

legalimpurity avatar Aug 15 '24 17:08 legalimpurity

@dyladan would you have time to review this today? I think @pichlermarc is on leave.

yes. i have a meeting about to start but i'll review this after

dyladan avatar Aug 15 '24 17:08 dyladan

Thanks for the review @dyladan. All review comments have been addressed. I have documented the limited amount of sampling operations that this sampler supports based on the specs here . Here is a link to all the Sampling configurations that Jaeger has.

legalimpurity avatar Aug 16 '24 16:08 legalimpurity

please also run npm install --package-lock-only so that the new package is added to package-lock.json.

pichlermarc avatar Aug 22 '24 12:08 pichlermarc

please also run npm install --package-lock-only so that the new package is added to package-lock.json.

done.

legalimpurity avatar Aug 22 '24 13:08 legalimpurity

Ah one npm run lint:fix is still needed - then this is good to go. :slightly_smiling_face:

pichlermarc avatar Aug 22 '24 13:08 pichlermarc

Ah one npm run lint:fix is still needed - then this is good to go. 🙂

done.

legalimpurity avatar Aug 23 '24 04:08 legalimpurity