opentelemetry-js icon indicating copy to clipboard operation
opentelemetry-js copied to clipboard

feat(instrumentation): added synchronous gauge

Open clintonb opened this issue 1 year ago • 7 comments

Which problem is this PR solving?

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #4296

Short description of the changes

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ ] Test A

Checklist:

  • [x] Followed the style guidelines of this project
  • [ ] Unit tests have been added
  • [ ] Documentation has been updated

clintonb avatar Mar 07 '24 06:03 clintonb

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: clintonb / name: Clinton Blackburn (40dcdede211a6041547010f307bbfb5eb4b05091, 71ed8a00f353662e968757bac0b25ce00f0bf0a9, c40fc1de516a3e1b6ea5a48a554af41ac527aa4a, 5da7a9d7b23ec937b4221d91a37ab22f7e295ef1)

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.84%. Comparing base (2610122) to head (313ce47). Report is 35 commits behind head on main.

:exclamation: Current head 313ce47 differs from pull request most recent head 5da7a9d

Please upload reports for the commit 5da7a9d to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4528      +/-   ##
==========================================
+ Coverage   90.77%   92.84%   +2.07%     
==========================================
  Files          90      328     +238     
  Lines        1930     9524    +7594     
  Branches      417     2050    +1633     
==========================================
+ Hits         1752     8843    +7091     
- Misses        178      681     +503     
Files Coverage Δ
api/src/metrics/Metric.ts 100.00% <ø> (ø)
api/src/metrics/NoopMeter.ts 95.34% <80.00%> (-2.02%) :arrow_down:

... and 244 files with indirect coverage changes

codecov[bot] avatar Mar 13 '24 15:03 codecov[bot]

@pichlermarc let me know if there is anything I need to do here and/or next steps.,

clintonb avatar Apr 04 '24 05:04 clintonb

@pichlermarc let me know if there is anything I need to do here and/or next steps.,

Sorry this is taking so long.

Turns out we need to figure out a way to add experimental metrics features to the API package as we've never done it before with new Instruments. I've opened a prototype PR to look into that #4622.

pichlermarc avatar Apr 10 '24 15:04 pichlermarc

@pichlermarc please review. 🤞🏾

clintonb avatar May 06 '24 07:05 clintonb

@pichlermarc one more look?

clintonb avatar May 06 '24 15:05 clintonb

Failing test is unrelated to this change.

clintonb avatar May 06 '24 15:05 clintonb

@pichlermarc fixes implemented

clintonb avatar May 15 '24 20:05 clintonb

@pichlermarc what are the next steps? Do you merge, or someone else?

clintonb avatar May 18 '24 20:05 clintonb