opentelemetry-js icon indicating copy to clipboard operation
opentelemetry-js copied to clipboard

Support Experimental metrics from semantic_conventions/http-metrics (1.23.1)

Open pragmaticivan opened this issue 1 year ago • 3 comments

Is your feature request related to a problem? Please describe.

Currently, we have to implement these metrics via middleware. But I assume they should be coming from instrumentation packages. To foster better organization I would like to point engineers to use the supported instrumentation libraries by opentelmetry-js.

Describe the solution you'd like

Support: Metric: http.server.active_requests Metric: http.server.request.body.size Metric: http.server.response.body.size

And: Metric: http.client.request.body.size Metric: http.client.response.body.size

^ if possible

Describe alternatives you've considered

I had to create a middleware to implement these metrics.

Additional context

The Java client has implemented these metrics already: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/09940563658c20076b3cc3df3ed7c792a55c4049/instrumentation-api-semconv/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/http/HttpServerExperimentalMetrics.java#L59

pragmaticivan avatar Dec 03 '23 15:12 pragmaticivan

This ticket might be fully blocked by https://github.com/open-telemetry/opentelemetry-js/issues/4235

pragmaticivan avatar Dec 03 '23 16:12 pragmaticivan

I tried implementing the active_requets metrics but the attributes are out of compliance with the latest spec.

pragmaticivan avatar Dec 03 '23 16:12 pragmaticivan

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Feb 26 '24 06:02 github-actions[bot]

This issue was closed because it has been stale for 14 days with no activity.

github-actions[bot] avatar Mar 18 '24 06:03 github-actions[bot]