opentelemetry-js icon indicating copy to clipboard operation
opentelemetry-js copied to clipboard

chore(opentelemetry-core): Rename ImplementationLibrary to ImplementationScope

Open bryantkale opened this issue 2 years ago • 7 comments
trafficstars

Which problem is this PR solving?

Fixes #2937

Fixes # (issue)

This PR replaces all instances of ImplementationLibrary with ImplementationScope

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit tests have been updates

Checklist:

  • [x] Followed the style guidelines of this project
  • [x] Unit tests have been added
  • [x] Documentation has been updated

bryantkale avatar Nov 09 '23 18:11 bryantkale

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: bryantkale / name: Caelin Bryant (2865c3718009920b29af7d01bf517d7074a6454c, 23e5ca030c0075aa965a3768da37192849741350, 31bf28522891f289e68703abbf3bb246156a9f2d, db757037aea86ba4ec4bc8918257b093c8e1afa5, ec1428e474d5ec2b2eaf0f3c13c510ceebb81000, 5219150cbea18ce128504f93f6325aef06b18af4)
  • :white_check_mark: login: dyladan / name: Daniel Dyla (e316af949e19207e9f758cb284156640f5fd0b48, 602fda360c25e80a9596ad4619e7aa8eba87aa89, d7084422e393424b8af9c45f38f9b9f376cebb56, 8ebed75e56fdda47bf80825682b07a224ffb27c2)
  • :white_check_mark: login: pichlermarc / name: Marc Pichler (fa76e3038dd6283dc18cbc0a6ca6c8f1292c74d0)

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.27%. Comparing base (b36ab12) to head (fa76e30). Report is 80 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4278      +/-   ##
==========================================
+ Coverage   92.23%   92.27%   +0.04%     
==========================================
  Files         334      332       -2     
  Lines        9463     9436      -27     
  Branches     2009     1996      -13     
==========================================
- Hits         8728     8707      -21     
+ Misses        735      729       -6     
Files Coverage Δ
...ental/packages/otlp-transformer/src/trace/index.ts 100.00% <100.00%> (ø)
...ges/opentelemetry-exporter-jaeger/src/transform.ts 93.33% <100.00%> (ø)
packages/opentelemetry-sdk-trace-base/src/Span.ts 97.45% <100.00%> (-0.05%) :arrow_down:
...ackages/opentelemetry-sdk-trace-base/src/Tracer.ts 98.61% <100.00%> (ø)

... and 15 files with indirect coverage changes

codecov[bot] avatar Dec 01 '23 20:12 codecov[bot]

Can you also remove the deprecated InstrumentationLibary interface from @opentelemetry/core?

dyladan avatar Dec 01 '23 20:12 dyladan

Looks like you also need to run your linter

dyladan avatar Dec 01 '23 20:12 dyladan

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Apr 01 '24 06:04 github-actions[bot]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Jul 01 '24 06:07 github-actions[bot]