opentelemetry-js icon indicating copy to clipboard operation
opentelemetry-js copied to clipboard

Add attributes property to InstrumentationScope

Open martinkuba opened this issue 2 years ago • 4 comments
trafficstars

Is your feature request related to a problem? Please describe.

Per spec here, InstrumentationScope may hold additional attributes. The proto definition includes the attributes field.

martinkuba avatar Apr 26 '23 18:04 martinkuba

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Jun 26 '23 06:06 github-actions[bot]

This is as per spec, should it be able to stale out?

danopia avatar Jun 26 '23 08:06 danopia

whats the difference between this and #4365? or is it the same?

dermasmid avatar May 05 '24 11:05 dermasmid

This applies to the InstrumentationScope context that is applicable to spans, metrics, and logs. I think https://github.com/open-telemetry/opentelemetry-js/issues/4365 is specific to metrics.

martinkuba avatar May 06 '24 15:05 martinkuba