opentelemetry-js
opentelemetry-js copied to clipboard
fix(api): declare this parameter type in observable callbacks
trafficstars
Which problem is this PR solving?
Fixes https://github.com/open-telemetry/opentelemetry-js/issues/3293
Declare the this parameter types for the observable callbacks.
This should not be a breaking change as usages without this parameter to be the expected one are not working anyways.
Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
- [x] Existing code should continue to be able to compile without any touch.
Checklist:
- [x] Followed the style guidelines of this project
Codecov Report
Merging #3497 (f904549) into main (eecb800) will not change coverage. The diff coverage is
n/a.
Additional details and impacted files
@@ Coverage Diff @@
## main #3497 +/- ##
=======================================
Coverage 93.75% 93.75%
=======================================
Files 249 249
Lines 7610 7610
Branches 1587 1587
=======================================
Hits 7135 7135
Misses 475 475