opentelemetry-js icon indicating copy to clipboard operation
opentelemetry-js copied to clipboard

chore: sanitize http.url attribute values

Open daniel-white opened this issue 2 years ago • 5 comments
trafficstars

Which problem is this PR solving?

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

I added a map of semantic attributes to a value sanitizing function. also made this work for one off values.

Errata: I'm not sure if you want to classify this as a breaking change or not. Also, I'm not sure why my tests are failing. Any vscode+mocha tips appreciated!

Fixes #2000

Short description of the changes

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ ] added unit tests

Checklist:

  • [x] Followed the style guidelines of this project
  • [x] Unit tests have been added
  • [] Documentation has been updated

daniel-white avatar Dec 14 '22 03:12 daniel-white

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: daniel-white / name: Daniel A. White (b4c4cbcd68a255164b532d7a63bb1cc002ad57f8)

i'm not sure what i need to do - i accepted as an individual contributor for the cla, but it says it is not enabled for this project.

daniel-white avatar Dec 14 '22 03:12 daniel-white

Are you signing the CLA with the email used to commit?

legendecas avatar Dec 15 '22 03:12 legendecas

thanks @osherv for the review - i'm working on your feedback.

do you have any tips on how that i can debug in vscode?

daniel-white avatar Dec 19 '22 18:12 daniel-white

@daniel-white sure! unfortunately i'm working in Webstorm, i can help you debug with Webstorm 😅

osherv avatar Dec 19 '22 18:12 osherv

i know my tests/lint are failing. however, i'd like to confirm that this is the pattern you all would like to go with

daniel-white avatar Dec 27 '22 21:12 daniel-white

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Apr 03 '23 06:04 github-actions[bot]

This PR was closed because it has been stale for 14 days with no activity.

github-actions[bot] avatar Jun 12 '23 06:06 github-actions[bot]