opentelemetry-js icon indicating copy to clipboard operation
opentelemetry-js copied to clipboard

Bring API package back into main repo

Open dyladan opened this issue 3 years ago • 5 comments
trafficstars

During the SIG meeting today we discussed the idea of bringing the API back into the main repo. Originally we split it out in order to ensure we didn't accidentally make breaking changes and to promote stability and intentional changes. Since then, the pain of updating the API to add new methods has proven to be worse than the value we gain by having the API in a separate repository. Creating this issue to get the opinions of those who are not able to regularly attend SIG meetings.

/cc @open-telemetry/javascript-maintainers

dyladan avatar Aug 31 '22 19:08 dyladan

Is it planned to include API into the lerna project and release together with SDK/experimental or is it just moved to have it in the same repo but keep release independent of each other?

Flarna avatar Sep 01 '22 08:09 Flarna

Is it planned to include API into the lerna project and release together with SDK/experimental or is it just moved to have it in the same repo but keep release independent of each other?

AFAICT, we are releasing experimental packages separately from the stable packages, with different versions. Though, the experimental packages are typically released simultaneously with the stable packages.

legendecas avatar Sep 02 '22 03:09 legendecas

I'm fine with that, i would say that it may be worth to add it into the lerna project but in a dedicated top-level directory to make a difference with sdks components ?

vmarchaud avatar Sep 02 '22 15:09 vmarchaud

Is it planned to include API into the lerna project and release together with SDK/experimental or is it just moved to have it in the same repo but keep release independent of each other?

AFAICT, we are releasing experimental packages separately from the stable packages, with different versions. Though, the experimental packages are typically released simultaneously with the stable packages.

We are actually releasing everything together but with different versions.

Dedicated top-level dir seems ok to me if that's how we want to go. Maybe we rename packages/ to sdk/?

I definitely want it in the lerna repo since that is the main advantage of moving it.

dyladan avatar Sep 02 '22 16:09 dyladan

I think we should avoid releasing API if there are no changes. But I guess this can be archived also here as it's done also in contrib.

Flarna avatar Sep 02 '22 22:09 Flarna

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Nov 07 '22 06:11 github-actions[bot]

API package has been moved in the main repo. Closing as done. Please feel free to reopen if there is anything left to be done.

legendecas avatar Nov 07 '22 06:11 legendecas