Moving browser instrumentation packages to opentelemetry-js/experimental

[scheler]

• [x] This only affects the JavaScript OpenTelemetry library
• [ ] This may affect other libraries, but I would like to get opinions here first

Are there any concerns moving the following packages/plugins in contrib repo into opentelemetry-js/experimental/packages since they are not for 3rd party libraries but for core browser functionality.

• plugins/web/opentelemetry-instrumentation-document-load
• plugins/web/opentelemetry-instrumentation-long-task
• plugins/web/opentelemetry-instrumentation-user-interaction

We can leave the following one out as it is react specific.

• plugins/web/opentelemetry-plugin-react-load

[vmarchaud]

I know there was some discussion around user intereaction instrumentation about how to map to spans (https://github.com/open-telemetry/opentelemetry-js-contrib/pull/980, https://github.com/open-telemetry/opentelemetry-js-contrib/pull/743). Honestly i feel its much better to keep them contrib until the RUM SIG has stabilized specification around the data model since it will be much easier to iterate on them

[scheler]

These are not stable for sure. The ask is only to move them into experimental folder since they instrumentations are not for 3rd party libraries.

[vmarchaud]

. The ask is only to move them into experimental folder since they instrumentations are not for 3rd party libraries.

There are packages for non-3rd party libraries in contrib as well (ex https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/packages/opentelemetry-host-metrics, https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/propagators/opentelemetry-propagator-ot-trace or https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/instrumentation-fs).

I don't see what would be gained from moving them in the core apart being more complicated to deploy TBH

[scheler]

This is not a strong ask, just something I found confusing as the fetch and xhr instrumentations are in the core repo.

[dyladan]

This is not a strong ask, just something I found confusing as the fetch and xhr instrumentations are in the core repo.

I agree this is a bit confusing since we don't really have an official policy. At the time we made the contrib repo we moved all instrumentations we didn't view as "core" functionality. Since we weren't focusing on RUM usecases at the time that included most browser instrumentations. Fetch and XHR were kept because they represent the minimum to have a useful trace.

I would almost argue the opposite: that we should move the existing instrumentations in the main repo into the contrib repo so that the load can be shared among a larger set of contributors using the module ownership mechanism there.

[github-actions[bot]]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[github-actions[bot]]

This issue was closed because it has been stale for 14 days with no activity.