opentelemetry-js
opentelemetry-js copied to clipboard
deps: update web dev deps
Update web dependencies to latest
Codecov Report
Merging #3167 (cad629a) into main (3cca2ce) will decrease coverage by
0.39%. The diff coverage is100.00%.
@@ Coverage Diff @@
## main #3167 +/- ##
==========================================
- Coverage 93.23% 92.83% -0.40%
==========================================
Files 196 181 -15
Lines 6414 5680 -734
Branches 1350 1203 -147
==========================================
- Hits 5980 5273 -707
+ Misses 434 407 -27
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...ckages/opentelemetry-core/src/utils/environment.ts | 91.22% <100.00%> (+0.31%) |
:arrow_up: |
| packages/opentelemetry-resources/karma.worker.js | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| ...kages/opentelemetry-sdk-trace-base/karma.worker.js | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| ...lemetry-resources/src/detectors/BrowserDetector.ts | 53.33% <0.00%> (-46.67%) |
:arrow_down: |
| ...lemetry-resources/src/detectors/ProcessDetector.ts | 95.45% <0.00%> (-4.55%) |
:arrow_down: |
| ...ation-xml-http-request/src/enums/AttributeNames.ts | ||
| ...emetry-instrumentation-xml-http-request/src/xhr.ts | ||
| .../src/platform/browser/export/BatchSpanProcessor.ts | ||
| ...ckages/opentelemetry-sdk-trace-web/karma.worker.js | ||
| ...-instrumentation-fetch/src/enums/AttributeNames.ts | ||
| ... and 10 more |
The reference of process.nextTick in https://github.com/open-telemetry/opentelemetry-js/blob/main/experimental/packages/opentelemetry-sdk-metrics-base/test/export/TestMetricExporter.ts#L24 can be replaced with common API queueMicrotask to support web environments properly.
The reference of
process.nextTickin https://github.com/open-telemetry/opentelemetry-js/blob/main/experimental/packages/opentelemetry-sdk-metrics-base/test/export/TestMetricExporter.ts#L24 can be replaced with common APIqueueMicrotaskto support web environments properly.
Ah I added the process module before seeing this. It implements the timing functions needed. queueMicrotask looks good but it doesn't support IE. I can't remember if we've made a decision on if we're supporting IE or not.
@dyladan queueMicrotask is equivalent to Promise.resolve().then(task) in some ways. Anyway, we use a lot of Promise in our code base and I suppose IE doesn't support it natively?
@dyladan queueMicrotask is equivalent to
Promise.resolve().then(task)in some ways. Anyway, we use a lot of Promise in our code base and I suppose IE doesn't support it natively?
Hmm didn't realize that. IE has been dead for a long time anyway so i'm not too worried about it.
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.
This PR was closed because it has been stale for 14 days with no activity.