PushMetricExporter forceFlush behavior

[hectorhdzg]

trafficstars

I'm building a Metrics Exporter for Azure Monitor and noticed some weird behavior in PushMetricExporter interface, this one is exposing forceFlush, I would expect the MetricReader to be the one having a reference to the actual metrics to export and just send them to the exporter whenever forceFlush is executed, currently PeriodicExportingMetricReader is just calling forceFlush in the exporter, instead of collecting the metrics and pass them to the exporter, is it expected for the Exporter to also collect the metrics whenever is a forceFlush executed?, how exactly forceFlush will work in the Exporter?

[hectorhdzg]

Same for selectAggregationTemporality this should be part of MetricReader and not Exporter, unless I'm missing how the PushMetric Exporter should work

[legendecas]

forceFlush stands for ensuring that the export of any Metrics the exporter has received and its returned promise indicates that the export is completed. Might be related: https://github.com/open-telemetry/opentelemetry-js/pull/3039#discussion_r904463781.

selectAggregationTemporality is needed to satisfy the requirements that a push metric exporter registered with a PeriodicExportingMetricReader can determine their preferred aggregation temporality as PeriodicExportingMetricReader doesn't have its own preference.

[legendecas]

After checking with the spec, I found that for a metric reader if the preferred aggregation temporality is not specified, AggregationTemporality.Cumulative should be used instead of consulting the underlying metric exporter:

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#metricreader

To construct a MetricReader when setting up an SDK, the caller SHOULD provide at least the following:

• ...
• The default output temporality (optional), a function of instrument kind. If not configured, the Cumulative temporality SHOULD be used.

/cc @seemk

[github-actions[bot]]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[github-actions[bot]]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[github-actions[bot]]

This issue was closed because it has been stale for 14 days with no activity.