opentelemetry-js icon indicating copy to clipboard operation
opentelemetry-js copied to clipboard

Add tests to reproduce bug with removeListener and once

Open ghisguth opened this issue 3 years ago • 3 comments
trafficstars

This is a reproducer for the bug listed in #2971

ghisguth avatar May 13 '22 21:05 ghisguth

CLA Missing ID CLA Not Signed

Codecov Report

Merging #2970 (dabfd1b) into main (22085fc) will decrease coverage by 2.43%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2970      +/-   ##
==========================================
- Coverage   92.52%   90.08%   -2.44%     
==========================================
  Files         183       68     -115     
  Lines        5980     1866    -4114     
  Branches     1268      399     -869     
==========================================
- Hits         5533     1681    -3852     
+ Misses        447      185     -262     
Impacted Files Coverage Δ
...s/opentelemetry-core/src/platform/node/sdk-info.ts 0.00% <0.00%> (-100.00%) :arrow_down:
...opentelemetry-core/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) :arrow_down:
...pentelemetry-core/src/platform/node/performance.ts 0.00% <0.00%> (-100.00%) :arrow_down:
...emetry-api-metrics/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) :arrow_down:
...lemetry-resources/src/detectors/ProcessDetector.ts 31.81% <0.00%> (-68.19%) :arrow_down:
...pentelemetry-resources/src/detectors/OSDetector.ts 26.66% <0.00%> (-60.00%) :arrow_down:
...ntelemetry-resources/src/detectors/HostDetector.ts 23.52% <0.00%> (-52.95%) :arrow_down:
...perimental/packages/otlp-exporter-base/src/util.ts 68.96% <0.00%> (-20.69%) :arrow_down:
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts 84.48% <0.00%> (-15.52%) :arrow_down:
...lemetry-resources/src/detectors/BrowserDetector.ts 93.33% <0.00%> (-6.67%) :arrow_down:
... and 115 more

codecov[bot] avatar May 14 '22 08:05 codecov[bot]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Jul 25 '22 06:07 github-actions[bot]

Closing this as it has been fixed by #3133. Thank you for providing the reproducer! :slightly_smiling_face:

pichlermarc avatar Sep 30 '22 06:09 pichlermarc