opentelemetry-js icon indicating copy to clipboard operation
opentelemetry-js copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Review SDK exports to ensure concrete classes are not used in interfaces

Open dyladan opened this issue 3 years ago • 2 comments
trafficstars

I guess such problems are not limited to SpanProcessor. Any exported class may result in similar problems. see the recent issue for contrib instrumentations.

I guess to fully avoid this it's needed to remove classes from all exports.

It is very possible. We can't remove those exports now unfortunately, but we can remove them from the interfaces we export. I'll create an issue to do a more thorough review.

Originally posted by @dyladan in https://github.com/open-telemetry/opentelemetry-js/issues/2931#issuecomment-1111140307

dyladan avatar Apr 27 '22 15:04 dyladan

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Jun 27 '22 06:06 github-actions[bot]

not stale

dyladan avatar Jun 27 '22 16:06 dyladan

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Sep 05 '22 06:09 github-actions[bot]

This issue was closed because it has been stale for 14 days with no activity.

github-actions[bot] avatar Sep 19 '22 06:09 github-actions[bot]