opentelemetry-js icon indicating copy to clipboard operation
opentelemetry-js copied to clipboard

HTTP Span Attributes: `http.url` must not contain username / password

Open pellared opened this issue 4 years ago • 11 comments
trafficstars

As is stated in the recent specification change :

http.url MUST NOT contain credentials passed via URL in form of https://username:[email protected]/. In such case the attribute's value should be https://www.example.com/

pellared avatar Mar 09 '21 12:03 pellared

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Aug 15 '22 06:08 github-actions[bot]

we should probably parse using URL and reserialize without username/password

dyladan avatar Aug 15 '22 15:08 dyladan

ill take this!

daniel-white avatar Dec 14 '22 01:12 daniel-white

@daniel-white Are you still working on this?

oldclesleycode avatar Jul 04 '23 06:07 oldclesleycode

@clesleycode 👋🏽 It's been a bit and I wonder if it'd make sense at this point to reassign?

What are your thoughts on this @legendecas ? What is the common wait time for reassigning a possibly abandoned issue?

mannyistyping avatar Jul 13 '23 03:07 mannyistyping

@mannyistyping you can definitely take the task if you are ready to work on it!

My opinion is still the same as https://github.com/open-telemetry/opentelemetry-js/pull/3487#discussion_r1058161289.

legendecas avatar Jul 13 '23 07:07 legendecas

I'd like to work on this.

GeorgeSaussy avatar Nov 08 '23 20:11 GeorgeSaussy

@GeorgeSaussy This PR seems to have stopped, and I would like to take on the challenge as Otel's First Commit, but could you please give it to me?

shoppingjaws avatar Jan 13 '24 05:01 shoppingjaws

@pkanal Hi I want to work on this issue, what should I do?

shoppingjaws avatar Jan 24 '24 02:01 shoppingjaws