opentelemetry-js-contrib icon indicating copy to clipboard operation
opentelemetry-js-contrib copied to clipboard

docs: Update instrumentation-runtime-node README.md

Open jeroenjanssen-cpp opened this issue 1 year ago • 6 comments

Which problem is this PR solving?

  • instrumentation-runtime-node README.md has wrong links pointing to instrumenation-pg

Short description of the changes

  • this corrects the links in the instrumentation-runtime-node README.md

jeroenjanssen-cpp avatar Nov 17 '24 08:11 jeroenjanssen-cpp

CLA Not Signed

Sorry, I didn't figure out up front how to CLA signing works from my company pov. (even though this is a small change) so I am getting that sorted out

jeroenjanssen-cpp avatar Nov 18 '24 14:11 jeroenjanssen-cpp

Np, you can also sign as an individual, not as part of a company.

maryliag avatar Nov 18 '24 15:11 maryliag

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.75%. Comparing base (5eb61d8) to head (b74a525). Report is 134 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2534   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files         169      169           
  Lines        8018     8018           
  Branches     1632     1632           
=======================================
  Hits         7277     7277           
  Misses        741      741           
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 18 '24 15:11 codecov[bot]

@jeroenjanssen-cpp have you signed the CLA? If so I can run the CI again :)

david-luna avatar Nov 25 '24 16:11 david-luna

Hi @jeroenjanssen-cpp Thank you for contributing this fix.

Are you still interested in finalizing this PR, or should we close it?

blumamir avatar Feb 12 '25 19:02 blumamir

Solved by #2786

maryliag avatar Apr 14 '25 12:04 maryliag