opentelemetry-js-contrib
opentelemetry-js-contrib copied to clipboard
feat: kafkajs instrumentation
Which problem is this PR solving?
Prerequisite for https://github.com/open-telemetry/opentelemetry-js-contrib/issues/1845
Short description of the changes
Adds the kafkajs instrumentation created by Aspecto which does not seem to be maintained any longer.
The codebase has been converted to TypeScript and differs from the original how the propagation headers are read (in this case they are read case insensitively, this fixes propagation issues across language SDKs). Added a NOTICE file attributing the original work and describing the changes.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.37%. Comparing base (
dfb2dff) to head (9ab3a87). Report is 127 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #2089 +/- ##
==========================================
- Coverage 90.97% 90.37% -0.61%
==========================================
Files 146 147 +1
Lines 7492 7502 +10
Branches 1502 1571 +69
==========================================
- Hits 6816 6780 -36
- Misses 676 722 +46
Thank you @seemk
@seemk
looks very good now :)
please fill the table in the readme as requested in https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2089/files#r1562439567 and you have my 👍
Another thought, should this new instrumentation be added to "@opentelemetry/auto-instrumentations-node" as part of this PR, or should it be done separately in a followup PR?
Please add some owners to the
.github/component_owners.yaml. Ideally that's two people so that PRs opened by one can be reviewed by the other.
Added myself, any ideas for the other one?
Another thought, should this new instrumentation be added to "@opentelemetry/auto-instrumentations-node" as part of this PR, or should it be done separately in a followup PR?
Will do it in a followup