opentelemetry-js-contrib
opentelemetry-js-contrib copied to clipboard
feat(resource-detector-aws): add support for cloud.resource_id to AWS ECS detector
Which problem is this PR solving?
Add support for cloud.resource_id in the AWS ECS detector.
Short description of the changes
Implement setting the ContainerARN as value to cloud.resource_id in the AWS ECS detector as discussed in this issue in semantic-conventions.
Since the OpenTelemetry SDK missing the enum entry for cloud.resource_id (to be fixed in this PR), a temporary enum is added to the package.
hey @zackman0010, we typically run instrumentation tests against the earliest version of an instrumented library that we support
the oshi instrumentation is a bit unique though in that we don't so much instrument it, as much as we require the user to bring it (so that it doesn't impact the javaagent jar size for everyone as it's several MB)
i'd support bumping the version we test against to 5.5.0, @laurit wdyt?
We have previously done one workaround for M1
https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/7ff3b23f101c41462850fc31ed0bc01229bd34c6/instrumentation/grpc-1.6/testing/build.gradle.kts#L40-L43
I think you can get the arch from osdetector and set the version to 5.5.0 when running on arm and osx (idk whether the osx check would be needed) and otherwise keep it at whatever it is now.