opentelemetry-js-contrib icon indicating copy to clipboard operation
opentelemetry-js-contrib copied to clipboard

wip: fix dual publish express

Open JamieDanielson opened this issue 2 years ago • 2 comments

Which problem is this PR solving?

Short description of the changes

WIP: attempting fix for dual-publishing CJS/ESM builds

JamieDanielson avatar Dec 11 '23 21:12 JamieDanielson

Codecov Report

Merging #1859 (75023bb) into main (3cb2802) will decrease coverage by 3.69%. Report is 1 commits behind head on main. The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1859      +/-   ##
==========================================
- Coverage   91.45%   87.76%   -3.69%     
==========================================
  Files         144       30     -114     
  Lines        7406     1790    -5616     
  Branches     1483      388    -1095     
==========================================
- Hits         6773     1571    -5202     
+ Misses        633      219     -414     

see 114 files with indirect coverage changes

codecov[bot] avatar Dec 11 '23 21:12 codecov[bot]

@JamieDanielson Wondering if this is still relevant and should be kept open.

blumamir avatar May 02 '24 14:05 blumamir

@JamieDanielson Wondering if this is still relevant and should be kept open.

I think this will be relevant and might be needed in all the packages... eventually. I guess the main question is to confirm whether this definitely works as expected and also determine the timeline to get these done. I've set it aside for now and will close as this can still be used as a guide even if closed.

JamieDanielson avatar May 23 '24 19:05 JamieDanielson