opentelemetry-js-contrib
opentelemetry-js-contrib copied to clipboard
feat: add support for graphql-tools-executor
Which problem is this PR solving?
- Some GraphQL server libraries, such as graphql-yoga, use @graphql-tools/executor instead of graphql.js built-in executor.
Short description of the changes
- Instrument @graphql-tools/executor
I have used the existing graphql.js excutor implementation as a reference, but if there is anything missing or incomplete in the testing or source code, I would be glad to hear about it.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: YutaUra / name: Yuta Ura (37e30a9bf2ace5ca991912f354d02bdd3cf68127)
@YutaUra Sorry we have not had a chance to review this and it has been a while. Is this something you are still interested in, and would you be willing to be a maintainer of the instrumentation? This will be important to know before we can give this a thorough review. Thanks!
Facing the same problem, it makes sense to have this instrumented aswell. Since these instrumentations are rather low-level it took hours to figure out, why the instrumentation did not work as expected.
@YutaUra Sorry we have not had a chance to review this and it has been a while. Is this something you are still interested in, and would you be willing to be a maintainer of the instrumentation? This will be important to know before we can give this a thorough review. Thanks!
If it helps to understand why I ask, here is a link to some new guidance we've written about new instrumentations getting added to this repo.
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.
This PR was closed because it has been stale for 14 days with no activity.