opentelemetry-js-api

opentelemetry-js-api copied to clipboard

Don't use lib dom during compilation

2

Currently tsconfig.json doesn't include a `lib` config. This results in automatically including dom - browser types (see https://www.typescriptlang.org/tsconfig#lib) The only place where this is needed is for global this [here](https://github.com/open-telemetry/opentelemetry-js-api/blob/ed9ba80427c34aa6397907eb2c28538ec74b5750/src/platform/browser/globalThis.ts#L19)...

Flarna

It looks like Renovate bot is not active in this repo. At least I can't fine a single PR and we still use e.g. typescript 4.1,... Besides that I think...

Flarna

Return suppressed instrumenation context from noop context manager

9

> Is this something we can/should improve in API? The main idea was to return Noop instances if version doesn't match but it should not crash nor end up in...

dyladan

Should NoopContextManager.active() return the context set by context.with()

5

Currently `NoopContextManager.active()` always returns `ROOT_CONTEXT`. This is somewhat strange if you consider following code as it looks like a basic contract is broken: ```js api.context.with(ctx, () => { api.context.active() //...

Flarna