opentelemetry-java icon indicating copy to clipboard operation
opentelemetry-java copied to clipboard

service.instance.id reference implementation

Open zeitlinger opened this issue 1 year ago • 1 comments

This is a reference implementation for the service.instance.id spec PR

zeitlinger avatar Feb 13 '24 07:02 zeitlinger

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.09%. Comparing base (98eded9) to head (62a2b6d).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6226      +/-   ##
============================================
+ Coverage     91.07%   91.09%   +0.01%     
- Complexity     5751     5757       +6     
============================================
  Files           626      627       +1     
  Lines         16782    16790       +8     
  Branches       1718     1718              
============================================
+ Hits          15285    15295      +10     
+ Misses         1003     1002       -1     
+ Partials        494      493       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 13 '24 08:02 codecov[bot]

Updated the PR to reflect the spec PR as it was merged.

zeitlinger avatar Feb 26 '24 15:02 zeitlinger

I agree that a release is desirable before merging this: until it's released, changes are always possible, even though they are unlikely for this specific case.

About it being experimental: I believe this change isn't causing backward compatibility issues, other than possibly for cardinality concerns when it comes to metrics. If possible, I'd love this to be opt-out, as it would help us make that semconv stable within a few releases.

jpkrohling avatar Mar 14 '24 09:03 jpkrohling