opentelemetry-java icon indicating copy to clipboard operation
opentelemetry-java copied to clipboard

Why does the property `otel.experimental.sdk.enabled` contains `experimental`

Open Emily-Jiang opened this issue 3 years ago • 9 comments

Is the property otel.experimental.sdk.enabled on the whole an experimental? If yes, when will it be stable? If not, why use the word experimental?

Emily-Jiang avatar Jul 07 '22 16:07 Emily-Jiang

Yes, it is experimental. It will be stabilized when we have a specification for it.

jkwatson avatar Jul 07 '22 18:07 jkwatson

Thanks @jkwatson for the confirmation! I assume the property name will be updated to something like otel.sdk.enabled when you stabilize it, right?

Emily-Jiang avatar Jul 07 '22 21:07 Emily-Jiang

Yes, the exact value will wait for the specification, but that's at least a reasonable guess.

jkwatson avatar Jul 07 '22 23:07 jkwatson

@jkwatson How can we help to make this property stable? Any idea on the remaining work?

brunobat avatar Jul 12 '22 18:07 brunobat

It needs to be added to the official spec. Not sure, but I think there's existing work ongoing.

jkwatson avatar Jul 12 '22 19:07 jkwatson

@jkwatson I would probably find out by checking out the code base. I am wondering whether you know for sure whether there is a programmatic api to switch on/off OTel (basically does the same thing as the configuration property otel.experimental.sdk.enabled.

Emily-Jiang avatar Jul 12 '22 20:07 Emily-Jiang

@jkwatson I would probably find out by checking out the code base. I am wondering whether you know for sure whether there is a programmatic api to switch on/off OTel (basically does the same thing as the configuration property otel.experimental.sdk.enabled.

IIRC, this just turns off all the configuration of the SDK, so returns the equivalent of just creating an SDK instance from a new builder with nothing else called on the builder.

jkwatson avatar Jul 12 '22 20:07 jkwatson

Will ask tomorrow on the Java meeting the best course of action.

brunobat avatar Jul 13 '22 08:07 brunobat

At yesterday's OTel Java meeting, this issue was discussed and we agreed on creating an issue at the spec level, to make this property permanent. Let's see the comments it gets.

brunobat avatar Jul 15 '22 10:07 brunobat

Resolved in #4810.

jack-berg avatar Oct 03 '22 16:10 jack-berg