opentelemetry-java icon indicating copy to clipboard operation
opentelemetry-java copied to clipboard

Check if we should preserve more of the Context in the OpenTracing shim.

Open Oberon00 opened this issue 5 years ago • 2 comments

Currently when a span is created in SpanBuilderShim.start, we only have the parent OpenTracing spanContext available. This means that we lose the originial full context when calling SpanProcessor.OnStart (not yet implemented with that parameter, but see https://github.com/open-telemetry/opentelemetry-specification/pull/875 and https://github.com/open-telemetry/opentelemetry-java/pull/1611#discussion_r493795647.

Oberon00 avatar Sep 24 '20 15:09 Oberon00

CC @carlosalberto

Oberon00 avatar Sep 24 '20 16:09 Oberon00

@carlosalberto @Oberon00 any idea if we need this still?

jkwatson avatar Aug 25 '21 22:08 jkwatson

Closing as I believe this is not needed. The opentracing shim spec is stable and says that spancontext and baggage are included in the context.

@carlosalberto feel free to re-open if you feel I've misinterpreted something.

jack-berg avatar Mar 10 '23 16:03 jack-berg