opentelemetry-java-instrumentation icon indicating copy to clipboard operation
opentelemetry-java-instrumentation copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Add code attributes to play mvc controller spans

Open jaydeluca opened this issue 10 months ago • 1 comments

Related to #7345

I know there are still discussions (here and here) around these conventions, but figured another example might help us continue to validate

Is this the right approach?

jaydeluca avatar Jan 31 '25 11:01 jaydeluca

Is this the right approach?

👍

cc @SylvainJuge

trask avatar Jan 31 '25 16:01 trask

I'd suggest the advice conversion work to be done in a different PR since the main problem with this PR is that the added code attribute isn't useful.

laurit avatar Jul 15 '25 13:07 laurit

I'd suggest the advice conversion work to be done in a different PR since the main problem with this PR is that the added code attribute isn't useful.

I ended up just switching this PR to focus on the advice conversion. If it would be cleaner to close this one and open a fresh one, I'm happy to do that.

jaydeluca avatar Jul 15 '25 19:07 jaydeluca

I ended up just switching this PR to focus on the advice conversion. If it would be cleaner to close this one and open a fresh one, I'm happy to do that.

Good idea, the scope of this PR is limited to play-2.4, there is also play-2.6 instrumentation that needs to be migrated, but this can be done in a separate PR.

SylvainJuge avatar Jul 16 '25 08:07 SylvainJuge

there is a failure in play 2.6 tests https://scans.gradle.com/s/36fci3go5n3se

laurit avatar Jul 17 '25 05:07 laurit