opentelemetry-java-instrumentation icon indicating copy to clipboard operation
opentelemetry-java-instrumentation copied to clipboard

Ktor 3.X support

Open FunkyMuse opened this issue 1 year ago • 5 comments

Is your feature request related to a problem? Please describe.

At the moment the Ktor 3.X open telemetry is not supported and the 2.0 support just doesn't work with Ktor 3.0

Describe the solution you'd like

It would be awesome to support Ktor open telemetry with target at ktor 3.X, even if it's in Beta 02 the compatibility with Kotlin 2.0 have already landed

Describe alternatives you've considered

None, as the migration to something else other than open telemetry doesn't make it feasible for us to do so.

Additional context

No response

FunkyMuse avatar Jul 31 '24 23:07 FunkyMuse

cc @marychatte

trask avatar Aug 01 '24 00:08 trask

Maybe create a PR if not added by open telemetry

FunkyMuse avatar Sep 06 '24 10:09 FunkyMuse

https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/10873 done few months ago but it's not merged yet

acunap avatar Sep 06 '24 13:09 acunap

#10873 done few months ago but it's not merged yet

why did you delete the PR? :/

FunkyMuse avatar Sep 09 '24 17:09 FunkyMuse

#10873 done few months ago but it's not merged yet

why did you delete the PR? :/

Tbh I was cleaning my repos and I accidentally deleted it 😆 In any case I don't think it was going to be merged and better to wait for Ktor's official solution.

acunap avatar Sep 16 '24 20:09 acunap

Ktor 3.0.0 is released

FunkyMuse avatar Oct 15 '24 12:10 FunkyMuse

Ktor 3.0.0 is released

Yes, we noticed it. We'd welcome a contribution for this.

steverao avatar Oct 15 '24 13:10 steverao

Ktor 3.0.0 is released

Yes, we noticed it. We'd welcome a contribution for this.

https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/12453

FunkyMuse avatar Oct 17 '24 12:10 FunkyMuse

Hey, guys is there any update on this ticket? Support from open telemetry is the only thing that block us for migrations to ktor 3. Do you have any ideas what have left and when we can expect this?

inakov avatar Nov 19 '24 08:11 inakov

Support has been released with their latest alpha release, I've already integrated otel and running jaeger in prod.

FunkyMuse avatar Nov 19 '24 10:11 FunkyMuse