opentelemetry-java-instrumentation icon indicating copy to clipboard operation
opentelemetry-java-instrumentation copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

WIP: Add coverage

Open robberphex opened this issue 1 year ago • 4 comments

  1. add jacoco to modules
  2. upload jacoco reports to codecov

https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/1555

robberphex avatar Mar 24 '24 03:03 robberphex

This PR is work in progress, and if there is any problem, please feedback here.

robberphex avatar Mar 24 '24 03:03 robberphex

Here is codecov example https://app.codecov.io/github/robberphex/opentelemetry-java-instrumentation/tree/release%2Fcodecov/instrumentation.

robberphex avatar Mar 24 '24 03:03 robberphex

Firstly see https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/conventions/src/main/kotlin/otel.jacoco-conventions.gradle.kts Currently we apply the jacoco conventions only to library instrumentations and sdk extensions, you also added it to some javaagent modules, does it actually report meaningful results for these?

laurit avatar Mar 25 '24 08:03 laurit

@laurit I noticed otel.jacoco-conventions.gradle. There's no need to add jacoco again. I am trying to figure out how to aggregate coverage reports.

robberphex avatar Mar 27 '24 06:03 robberphex