opentelemetry-java-instrumentation icon indicating copy to clipboard operation
opentelemetry-java-instrumentation copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

add ktor 3 instrumentation

Open acunap opened this issue 1 year ago • 4 comments

Hi! IntelliJ recently announced that they are going to release their official Ktor instrumentation library but there isn't any release date. So since the changes between Ktor 2 and Ktor 3 are minimal, I'd like to contribute with this library so we can instrument our apps right now.

acunap avatar Mar 15 '24 17:03 acunap

CLA Signed


The committers listed above are authorized under a signed CLA.

linux-foundation-easycla[bot] avatar Mar 15 '24 17:03 linux-foundation-easycla[bot]

I saw the codes, except one or two line are different from with module of ktor-2.0, others are same. Didn't Ktor-2.0 support version 3.0 after you tested it? If yes, is there any solution to support 3.0 by adjusting the codes in module of Ktor-2.0? BTW, Ktor-2.0 means its supporting at minimal supported version 2.0 instead of only supporting 2.0.

I don't think Ktor-2.0 could support version 3.0 since 3.0 introduce breaking change on its API and objects exposed publicly by server internals.

acunap avatar Mar 18 '24 10:03 acunap

Hi! IntelliJ recently announced that they are going to release their official Ktor instrumentation library but there isn't any release date.

Nice! Do you happen to have a link handy to this announcement? Thanks

trask avatar Mar 18 '24 19:03 trask

Hi! IntelliJ recently announced that they are going to release their official Ktor instrumentation library but there isn't any release date.

Nice! Do you happen to have a link handy to this announcement? Thanks

Sure thing, but it's no more than a few lines in their 2024 roadmap.

https://blog.jetbrains.com/kotlin/2024/03/the-ktor-roadmap-for-2024/#opentelemetry-plugins

In my first comment I said IntelliJ but... you know, Jetbrains 😆

acunap avatar Mar 18 '24 20:03 acunap