opentelemetry-java-contrib icon indicating copy to clipboard operation
opentelemetry-java-contrib copied to clipboard

Update JMX reported metrics

Open carlosalberto opened this issue 3 years ago • 3 comments
trafficstars

I've opened a pair of PRs to include the existing JMX metrics for JVM and Kafka Producer/Brokers. I'd love to have the review by the codeowners - specially as I'd like to go over the rest of the metrics, and I don't want that to be a surprise later.

@dehaansa @Mrod1598 @rmfitzpatrick

carlosalberto avatar Apr 12 '22 14:04 carlosalberto

@carlosalberto initially these additions look good, but it may be prudent to wait until the conversations around the long term support for the JMX metrics gatherer are further along (see #282)

dehaansa avatar Apr 12 '22 15:04 dehaansa

Thanks @dehaansa - I think there's value in defining them anyway, as we will need them one way or another.

Also, it may to your interest specifically that I'd like to (as mentioned in the PR) change some of the metrics from Gauges to UpDownCounters.

(On a related note, FYI, the used/committed/etc memory uses a different set of metrics in the OTel Specs, so I will sending a PR to adjust that in the jmx-metrics subproject.

carlosalberto avatar Apr 14 '22 13:04 carlosalberto

@dehaansa You maybe interested in the latest iterations in https://github.com/open-telemetry/opentelemetry-specification/pull/2485 - so far:

  • Most gauges have become UpDownCounters
  • Have left out of the semantic conventions a few metrics that can be synthesized as summary/histogram data points.

carlosalberto avatar May 04 '22 22:05 carlosalberto

Hey @carlosalberto -- this issue has been around for a while, and I think everything that's been linked to has been merged. Is there anything else actionable on this, or can we close it? 🙏🏻 Thanks.

breedx-splk avatar Sep 27 '23 21:09 breedx-splk

This has been automatically marked as stale because it has been marked as needing author feedback and has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

github-actions[bot] avatar Oct 04 '23 22:10 github-actions[bot]