opentelemetry-java-contrib icon indicating copy to clipboard operation
opentelemetry-java-contrib copied to clipboard

BaggageSpanProcessor should use ExtendedSpanProcessor.onEnding()

Open jameyg42 opened this issue 10 months ago • 3 comments

Component(s)

processors

Is your feature request related to a problem? Please describe.

Because BaggageSpanProcessor runs onStart(), newly added included Baggage keys need to be manually added to the current Span.

Describe the solution you'd like

BaggageSpanProcessor should be modified to implement ExtendedSpanProcessor and included baggage keys should be added onEnding().

Describe alternatives you've considered

No response

Additional context

No response

jameyg42 avatar Jan 02 '25 14:01 jameyg42

@zeitlinger @MikeGoldsmith any thoughts?

jkwatson avatar Jan 02 '25 16:01 jkwatson

Yes, we should do that

zeitlinger avatar Jan 02 '25 17:01 zeitlinger

@jameyg42 turns out that this feature request violates best practices - see https://github.com/open-telemetry/opentelemetry-java-contrib/pull/1633#issuecomment-2578006789

I therefore propose to close this issue.

zeitlinger avatar Jan 08 '25 16:01 zeitlinger