opentelemetry-java-contrib icon indicating copy to clipboard operation
opentelemetry-java-contrib copied to clipboard

Closing a JFR recording may throw an Exception

Open dsgrieve opened this issue 1 year ago • 1 comments

Component(s)

jfr-connection

What happened?

Description

Calling the Recording#close() method may throw an exception if the FlightRecorder MXBean closeRecording function fails. The behavior of the original microsoft/jfr-streaming code was to swallow the exception. The behavior of the contributed code is different and this has caused a regression in an application that uses this module.

Steps to Reproduce

Expected Result

The close() method on a Recording should not throw an exception.

Actual Result

Component version

1.37.0

Log output

No response

Additional context

No response

dsgrieve avatar Aug 12 '24 21:08 dsgrieve

PR #1412

dsgrieve avatar Aug 13 '24 12:08 dsgrieve

Resolved by #1412

trask avatar Sep 23 '24 16:09 trask