opentelemetry-java-contrib
opentelemetry-java-contrib copied to clipboard
Azure resource providers
Fixes #1214
Testing:
Has not been tested in a real setup yet - but all implementations are based on the existing resource providers in other languages.
Documentation:
done
Outstanding items
Owner
Need component owners. I can be one of them.
Host image attributes
VM seems to support host.image related attributes
host.image.id=host.image.name=host.image.version= <exactVersion>
(from https://learn.microsoft.com/en-us/azure/virtual-machines/instance-metadata-service?tabs=linux)
"imageReference": {
"id": "",
"offer": "UbuntuServer",
"publisher": "Canonical",
"sku": "16.04.0-LTS",
"version": "latest",
"communityGalleryImageId": "/CommunityGalleries/testgallery/Images/1804Gen2/Versions/latest",
"sharedGalleryImageId": "/SharedGalleries/1P/Images/gen2/Versions/latest",
"exactVersion": "1.1686127202.30113"
},
does that make sense?
Stop VM detector fast
Right now, the VM detector has a timeout of 1s - which means that it will block the startup process by 1s if we're not running in an Azure VM. How can we avoid that?
INFO: AzureVmResourceProvider.createResource took 1388 ms
An idea is to look for the /etc/resolv.conf file on linux - and some special registry key on windows.
Is that really the best option?
@trask here's my first attempt - can you help with testing?
@trask can you check?
@breedx-splk please check again
@breedx-splk please check again
Still looking good to me....though it would have been nice not to have a bunch of extra new additional code to review after an approval. 😅
@breedx-splk please check again
Still looking good to me....though it would have been nice not to have a bunch of extra new additional code to review after an approval. 😅
sorry - the PR was created before the new semconv policy - didn't spot that before
@breedx-splk should work now
@breedx-splk leftover from last year - can you check? :smile: