opentelemetry-java-contrib icon indicating copy to clipboard operation
opentelemetry-java-contrib copied to clipboard

Add xray propagators that prioritizes xray environment variable

Open tylerbenson opened this issue 2 years ago • 1 comments

This will allow support for AWS's environment variable with no additional config keys and no changes to instrumentation required.

I included a propagator that did just the env var propagation without the standard xray propagation as well as one that does both but prioritizes xray env propagation first.

tylerbenson avatar Sep 08 '23 19:09 tylerbenson

This is related to https://github.com/open-telemetry/semantic-conventions/pull/277

No decision was made yet.

rapphil avatar Sep 11 '23 21:09 rapphil

This PR has been updated to match the latest spec update and is now ready for review.

tylerbenson avatar Mar 05 '24 16:03 tylerbenson

@srprash @wangzlei please take a look.

tylerbenson avatar Mar 06 '24 16:03 tylerbenson

@wangzlei I don't think anything in our discussion above represents a blocker for merging this PR. Is there anything that I'm missing?

If you'd like to continue discussing how this should all work, we should probably include the rest of the SIG instead of in this repo. Please open an issue in the opentelemetry-lambda repo or come attend the SIG meeting.

tylerbenson avatar Mar 19 '24 19:03 tylerbenson