opentelemetry-helm-charts icon indicating copy to clipboard operation
opentelemetry-helm-charts copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Keep only two routers in filelog

Open VihasMakwana opened this issue 2 years ago • 6 comments
trafficstars

The CRI-O and contained logs are similar, <timestamp> <stdout|stderr> <logtag> <log message>

The timestamp is of the rfc3339Nano specification. The PR https://github.com/signalfx/splunk-otel-collector-chart/pull/817 has updated the timestamp to rfc3339Nano. I think we can keep two routers only:

One for docker One for cri-o/containerd

We can use the existing cri-o parser. It covers both, Zulu timestamps and timestamps with timezone info.

Related issue: https://github.com/signalfx/splunk-otel-collector-chart/issues/829

VihasMakwana avatar Jun 27 '23 06:06 VihasMakwana

I can work on this one as I'm working on the attached issue

VihasMakwana avatar Jun 27 '23 12:06 VihasMakwana

I like this, this would simplify the config a bit :)

povilasv avatar Jun 30 '23 09:06 povilasv

Is this a non-breaking change?

TylerHelmuth avatar Jun 30 '23 16:06 TylerHelmuth

yes, I believe.

VihasMakwana avatar Jun 30 '23 17:06 VihasMakwana

maybe I can roll out a PR and you guy can have a look?

VihasMakwana avatar Jun 30 '23 17:06 VihasMakwana

Sure. I'm most interested in ensuring that the data the the 2 separate routers were intending to capture really can be capture by the same router.

TylerHelmuth avatar Jun 30 '23 17:06 TylerHelmuth