open-telemetry
feat(demo): add ipv6 environment vars
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: gnmeyer / name: Grant Meyer (ab6af35c7a9b25ca253ef84fa54b9cb69dbb10f1)
- :white_check_mark: login: iturgut / name: Ilayda Turgut (ebc3692ca66f6d75d1a89ef64f1805bdfd6fb04d)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
@gnmeyer I'm a bit confused here. Do we need all those new rendered files, just for the IPv6 example? Isn't just this file enough? https://github.com/open-telemetry/opentelemetry-helm-charts/pull/1872/files#diff-060f881c5ce99f9f5f8721f35c1e7c615d225ff40c17e3983a3c0d77057c0607
This PR was marked stale due to lack of activity. It will be closed in 14 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
The rendered files were made from the make generate-examples command as a target from the Makefile.
Looking at the other examples, they also have the rendered out files. Unless one of the workflows runs the make generate-examples command, all of these files should be fine to be merged in.
The rendered files were made from the
make generate-examplescommand as a target from the Makefile. Looking at the other examples, they also have the rendered out files. Unless one of the workflows runs themake generate-examplescommand, all of these files should be fine to be merged in.
Yes, but that's because we are adding a "new" example. My question is, do we need that new example?
I'm asking because every single example we add, we have hundreds of extra lines of code generated, that need to be maintained.
Alright, that's fair. I reverted the example and kept the updates to the opentelemetry-demo/values.yaml
@gnmeyer you still need to bump the chart version and generate the examples 😅
The whole discussion was about adding a new set of examples. But every chart update needs a version bump and re-generation of existing examples.
@julianocosta89 I bumped one minor version, updated the documentation, and regenerate the examples
@gnmeyer / @iturgut can we get the lint fixed? It seems that there are some changes that shouldn't be part of this PR in here.
@julianocosta89 Thank you for your patience. When generating examples, it modified the kube-stack chart. Reverted those changes, now modifying only the otel demo chart