opentelemetry-helm-charts icon indicating copy to clipboard operation
opentelemetry-helm-charts copied to clipboard
verified publisher icon open-telemetry

feat(opentelemetry-collector): add automountServiceAccountToken param for sa

Open ppatel1604 opened this issue 6 months ago • 4 comments

The PR implements changes to fix the issue #1111. Changes are as below

  • Support for automountServiceAccountToken with a check to avoid breaking changes
  • Accepts the value for automountServiceAccountToken through helm values
  • Default value for automountServiceAccountToken as part of the values.yaml
  • opentelemetry-collector schema update
  • Example values files with true and false
  • Version bump

ppatel1604 avatar Jun 06 '25 23:06 ppatel1604

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: ppatel1604 / name: Parth Patel (9a19d65cdddcf41a838c8fe1ce91c3674328bf94, 8781ace1cd107c1be57bbaf7923deae32e4c6822, 6042dde90a3f7d33976c1c31c4df97a5f764c0a6, 2661496c84e611c0028a9ea3c1432d898a7e50de, 778189dd9c45ac8193357c4017f32ed893e726c1, 10d6ecc0585fb2f882b71daed0bfec4efcce24c7, e36d9c68e10d93deab59d513af86f9a73e1cea51, 121ae7502a4e3db06cd3313875886d1c34c52876)
  • :white_check_mark: login: TylerHelmuth / name: Tyler Helmuth (8eca475cd8ef2f8e3b7f2953f39bccf7400bfc68)

linux-foundation-easycla[bot] avatar Jun 06 '25 23:06 linux-foundation-easycla[bot]

@ppatel1604 are you by any chance generating the examples with an old version of helm? They are still out of sync. You can also simplify the generation with make generate-examples CHARTS=opentelemetry-collector

TylerHelmuth avatar Jun 12 '25 14:06 TylerHelmuth

@ppatel1604 are you by any chance generating the examples with an old version of helm? They are still out of sync. You can also simplify the generation with make generate-examples CHARTS=opentelemetry-collector

@TylerHelmuth Yes, I was using Helm 3.15 previously. I have just updated it to 3.18.1. I have also run make generate-examples CHARTS=opentelemetry-collector just now. No new changes. I can also confirm that the branch is up to date with the main branch. Locally make check-examples CHARTS=opentelemetry-collector works successfully. Not sure what I am doing wrong. I will try to find out and see if I can get it resolved.

ppatel1604 avatar Jun 13 '25 00:06 ppatel1604

When I checkout your branch and run make generate-examples CHARTS=opentelemetry-collector locally I do get changes.

TylerHelmuth avatar Jun 13 '25 15:06 TylerHelmuth

When I checkout your branch and run make generate-examples CHARTS=opentelemetry-collector locally I do get changes.

Thank you @TylerHelmuth. I have pulled latest changes and updated the examples. Can you please re-review this PR?

ppatel1604 avatar Jun 16 '25 20:06 ppatel1604