opentelemetry-helm-charts
opentelemetry-helm-charts copied to clipboard
add opentelemetry-ebpf-instrumentation helm chart
Helm chart for opentelemetry-ebpf-instrumentation, the helm chart is based on the original beyla helm chart
We need to discuss this chart addition in the issue first
Hey @TylerHelmuth, just added a comment in the issue. Hope it clarifies everything.
@mariomac iv'e added to k8s cache to the helm chart, so i would love a re-review
@TylerHelmuth i see that mario has approved what are the next steps to get this merged?
This PR was marked stale due to lack of activity. It will be closed in 14 days.
hey @TylerHelmuth, are you available for a review of this?
@TylerHelmuth fixed all comments except changing the chart name @MrAlias @mariomac wdyt the name should be?
@NimrodAvni78 the name that we use for the executable and the docker image is ebpf-instrument. Maybe we can use it? The open-telemetry prefix will be already present, e.g.:
helm install my-obi open-telemetry/ebpf-instrument
The pattern to match is to include opentelemetry- in the chart some. So we could so open-telemetry/opentelemetry-ebpf-instrument if that matches the image name.
docs are currently misleading - https://opentelemetry.io/docs/zero-code/obi/setup/kubernetes-helm/ - the chart is not yet available in the charts repository. when will it be available and what is the alternative until it happens? @NimrodAvni78
@roimor-aiola You can directly clone the charts from https://github.com/coralogix/opentelemetry-helm-charts/tree/otel-ebpf-instrumentation branch and locally apply helm charts using
helm upgrade --install ebpf ./charts/opentelemetry-ebpf-instrumentation
--namespace otel-ebpf \
This should unblock you untill it's merged on mainline.
This PR was marked stale due to lack of activity. It will be closed in 14 days.
@RaghavAwasthi what a terrible solution. why not merge this PR already?
Why are there so many images and projects for eBPF? I keep looking for documentation but keep coming up empty handed... There are all these different collectors over at https://github.com/open-telemetry/opentelemetry-network that are used in https://github.com/open-telemetry/opentelemetry-helm-charts/tree/main/charts/opentelemetry-ebpf, but what the heck is the difference between all of these? I feel like the documentation around all this needs to be updated.
This PR was marked stale due to lack of activity. It will be closed in 14 days.
Great
Can this please get approved since it actually works, then any other fixes and what not can be applied?
@TylerHelmuth @MrAlias @povilasv after the release of OBI 0.1.0 we have a stable docker image I think we are ready to release this now