opentelemetry-helm-charts icon indicating copy to clipboard operation
opentelemetry-helm-charts copied to clipboard

[opentelemetry-ebpf-instrumentation] add new helm chart

Open NimrodAvni78 opened this issue 5 months ago • 11 comments

add new helm chart for opentelemetry-ebpf-instrumentation

NimrodAvni78 avatar Jun 05 '25 07:06 NimrodAvni78

opened a PR https://github.com/open-telemetry/opentelemetry-helm-charts/pull/1704

NimrodAvni78 avatar Jun 05 '25 12:06 NimrodAvni78

Is this different than https://github.com/open-telemetry/opentelemetry-helm-charts/tree/main/charts/opentelemetry-ebpf?

You'll need to recruit a SIG member from that repository to help maintain this chart.

TylerHelmuth avatar Jun 05 '25 14:06 TylerHelmuth

hey @TylerHelmuth thanks for the response opentelemetry-ebpf helm chart refers to opentelemetry-network helm this repo is for opentelemetry-ebpf-instrumentation those are different repos even though the naming is similar

not super sure what you mean by SIG memory from that repo, can you elaborate?

NimrodAvni78 avatar Jun 05 '25 15:06 NimrodAvni78

Typo, I meant to say sig member

TylerHelmuth avatar Jun 05 '25 15:06 TylerHelmuth

How do those two repos interact? Would they every be installed together?

TylerHelmuth avatar Jun 05 '25 15:06 TylerHelmuth

How do those two repos interact? Would they every be installed together?

@TylerHelmuth from the Beyla Due Diligence document:

Based on talks between Jonathan Perry and Nikola Grcevski … The conclusion is that the Beyla donation will supersede this project in the long run. OTel will recommend switching to the Beyla donation once feature parity is reached with the current network monitoring.

ittai-coralogix avatar Jun 05 '25 21:06 ittai-coralogix

Hmmm. That makes me think it should be a feature in the existing chart.

TylerHelmuth avatar Jun 05 '25 22:06 TylerHelmuth

I endorse this helm chart creation.

The previous opentelemetry-ebpf helm chart belongs ot the opentelemetry-network project, which at the moment has 0% feature overlap with opentelemetry-ebpf-instrumentation (both can provide network metrics but none of them follow the same specification).

mariomac avatar Jun 06 '25 07:06 mariomac

@mariomac as a maintainer of opentelemetry-ebpf-instrumentation can you help with this chart?

TylerHelmuth avatar Jun 06 '25 14:06 TylerHelmuth

@TylerHelmuth sure! @ittai-coralogix is regularly joining the opentelemetry-ebpf-instrumentation weekly SIG meetings and we are in touch about this issue.

mariomac avatar Jun 06 '25 14:06 mariomac

Ok. To start, please review the current open PR for all thing related to your application. I'll take a look next week at some of the admin stuff we need charts in this repo to abide by.

TylerHelmuth avatar Jun 06 '25 14:06 TylerHelmuth

To ensure this new chart is managed consistently with the rest of the charts in this repository, I’d recommend implementing the following or filing follow-up issues to track them:

  • Update the root README.md to include a reference to the new chart.
  • Integrate the chart with the Makefile for consistent tooling support.
  • Add at least one example and ensure it’s is rendered via `make generate-examples', this helps catch breaking changes early.

jvoravong avatar Jun 18 '25 20:06 jvoravong

@jvoravong done

NimrodAvni78 avatar Jun 19 '25 08:06 NimrodAvni78