opentelemetry-helm-charts icon indicating copy to clipboard operation
opentelemetry-helm-charts copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

[collector] Only use internalTrafficPolicy: if on Kubernetes vesrion 1.26 or later

Open Uncle-Justice opened this issue 1 year ago • 3 comments

following this PR, we have to make limits based on k8s version.

Otherwise we will fail to install collector when k8s version is low

Uncle-Justice avatar Jul 19 '24 09:07 Uncle-Justice

@Uncle-Justice you linked to a PR that is in a non-opentelemetry organization. I'm not sure what the issue is that you're trying to fix. We try not to add kubernetes-specific-version logic to the chart as it makes it a little harder to maintain and normally we can avoid it. Can you please open an issue to describe your problem in more detail?

TylerHelmuth avatar Jul 19 '24 14:07 TylerHelmuth

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Aug 03 '24 02:08 github-actions[bot]

@Uncle-Justice, was this change in reference to the K8s versioning mentioned here?

bixu avatar Aug 15 '24 16:08 bixu

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Aug 30 '24 02:08 github-actions[bot]

Closed as inactive. Feel free to reopen if this PR is still being worked on.

github-actions[bot] avatar Sep 13 '24 02:09 github-actions[bot]