opentelemetry-helm-charts icon indicating copy to clipboard operation
opentelemetry-helm-charts copied to clipboard

[opentelemetry-operator] allow to override repositories without need to overwrite tag

Open sumo-drosiek opened this issue 1 year ago • 4 comments
trafficstars

We would like to be able to use own docker registry for example for metricsAllocator. Now it we want to do it, we need to specify tag as well, which is problematic as it has to be updated every time we would like to update the chart and use the default version. I think that it should use appVersion as default tag value.

Here is the code which requires both tag and repository values.

sumo-drosiek avatar Apr 09 '24 12:04 sumo-drosiek

Although typically appVersion corresponds directly with the thing being installed, I think since the operator version and target allocator version and auto-instrumentation versions are so closely related I'd be ok using appVersion across all those images.

I do not want to use it for the collector tag.

TylerHelmuth avatar Apr 10 '24 17:04 TylerHelmuth

@TylerHelmuth I have also the question a bit related to that. Would it be fine to move collectors tag and repo to CRD? I imagine there may be some scenarios when users would like to have multiple collectors/distros and one operator 🤔

sumo-drosiek avatar Apr 11 '24 08:04 sumo-drosiek

The OpenTelemetryCollector CRD allows you to specify the collector image it uses. The collector image in the chart sets the Operator's default collector image, but the CRD allows overriding. The operator chart does not install OpenTelemetryCollector CRs.

TylerHelmuth avatar Apr 11 '24 15:04 TylerHelmuth

@TylerHelmuth I started working on that and after all I see two possible solutions:

  • write everything explicitly in values.yaml (preferred by me, but may be harder to maintain)
  • use appVersion as default version and .Values.manager.image.repository as default repository (less overrides if customer wants to change repository)

As there are two parts which may be overwritten, both of them needs defaults or both of them needs to be always set. I think it's more clear and transparent to set both of them in values.yaml

sumo-drosiek avatar Apr 19 '24 07:04 sumo-drosiek