opentelemetry-go icon indicating copy to clipboard operation
opentelemetry-go copied to clipboard
verified publisher icon open-telemetry

[WIP] Bad log message fix and refactor

Open shri-acha opened this issue 5 months ago • 3 comments

Replaced the log messages for now, have to work on removing the drop count as will be discussed in #6983 .

shri-acha avatar Jul 09 '25 15:07 shri-acha

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: shri-acha / name: irhs0 (40f6860685af63ebc660ca95d7feb5c8b50b8365, 0589a3ebc50acfda457ba789479f03c22bd6dd1c, 27767193ee08a9e39ba086b697e3b760f7d2371a, 4fae0e60698b342a9110e4d0f267c192a6b53513)

linux-foundation-easycla[bot] avatar Jul 09 '25 15:07 linux-foundation-easycla[bot]

I've made the changes @pellared . I'm still unsure about how I have to deal with the tests.

shri-acha avatar Jul 16 '25 02:07 shri-acha

I've made the changes @pellared .

Can you please update the branch and resolve conficts?

I'm still unsure about how I have to deal with the tests.

Update/fix them if they do not test the expected behavior. Also add any missing ones (e.g. for the new log message). It would be also good to add a test for regression that the log messages are not emitted when everything is fine (no deduplication and none limit has been exceeded).

pellared avatar Jul 16 '25 09:07 pellared